feat/fix: differentiate PDA vibration popup recipients#2034
Open
re-silvered wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Changes the PDA ringer system to give different chat popups depending on whose PDA is ringing, no longer will you be told your PDA is ringing when its actually someone else's nearby!
Why / Balance
Previously it just stated "Your PDA vibrates" even if it wasn't your own if someone was close enough to you, with this it will accurately say whose PDA now that's going off, with a little bit of a range increase from 1 tiles to 2
Technical details
Refactors the popup to send two different alerts:
One for the sender, that everyone else is excluded from seeing
One for others, that the sender is excluded from seeing, and is range limited to two tiles (0.1f) with a fallback if no owner is found (e.g PDA laying on the ground)
How to test
With two clients -> Stand them within 2 tiles of each other -> post a bounty with one -> see the different messages -> stand further than two tiles away -> don't see the different messages.
Media
Changelog
🆑